Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't allow to make reposting for the closed period #35118

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented May 1, 2023

Issue

Users are able to make Repost Item Valuation entries for the closed period due to which the closing balance get changed for the closed period

#no-docs

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #35118 (f751727) into develop (787313b) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35118   +/-   ##
========================================
  Coverage    63.68%   63.69%           
========================================
  Files          813      813           
  Lines        60019    60034   +15     
========================================
+ Hits         38226    38241   +15     
  Misses       21793    21793           
Impacted Files Coverage Δ
...ype/repost_item_valuation/repost_item_valuation.py 72.34% <87.50%> (+1.24%) ⬆️

... and 2 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit a10aab3 into frappe:develop May 1, 2023
rohitwaghchaure added a commit that referenced this pull request May 1, 2023
…-35118

fix: don't allow to make reposting for the closed period (backport #35118)
rohitwaghchaure added a commit that referenced this pull request May 2, 2023
…-35118

fix: don't allow to make reposting for the closed period (backport #35118)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant