Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ineffective bypass flag for Credit Limit in Customer Group #35142

Merged
merged 1 commit into from
May 8, 2023
Merged

fix: ineffective bypass flag for Credit Limit in Customer Group #35142

merged 1 commit into from
May 8, 2023
+6 −2

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented May 3, 2023 •
edited
Loading

Bypass flag for Credit Limit in Customer Group wasn't working. Fixing in this PR
Screenshot 2023-05-03 at 4 41 55 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #35142 (f9a4972) into develop (7e24215) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35142      +/-   ##
===========================================
- Coverage    63.70%   63.69%   -0.02%     
===========================================
  Files          813      813              
  Lines        60053    60066      +13     
===========================================
+ Hits         38256    38258       +2     
- Misses       21797    21808      +11
Impacted Files Coverage Δ
erpnext/selling/doctype/customer/customer.py 75.67% <66.66%> (-0.18%) ⬇️

... and 4 files with indirect coverage changes

@ruthra-kumar ruthra-kumar changed the title fix: bypass flag in Customer Group wasn't effective fix: ineffective bypass flag for Credit Limit in Customer Group May 3, 2023
@ruthra-kumar ruthra-kumar marked this pull request as ready for review May 8, 2023 08:07
@ruthra-kumar ruthra-kumar merged commit 6315d9f into frappe:develop May 8, 2023
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label May 8, 2023
@mergify mergify bot mentioned this pull request May 8, 2023
Merged
ruthra-kumar added a commit that referenced this pull request May 8, 2023
@ruthra-kumar
Merge pull request #35208 from frappe/mergify/bp/version-14-hotfix/pr…
fd09d1c 
…-35142

fix: ineffective bypass flag for Credit Limit in Customer Group (backport #35142)
@mergify mergify bot mentioned this pull request May 18, 2023
Merged
ruthra-kumar added a commit that referenced this pull request May 18, 2023
@ruthra-kumar
Merge pull request #35356 from frappe/mergify/bp/version-13-hotfix/pr…
6191cfe 
…-35142

fix: ineffective bypass flag for Credit Limit in Customer Group (backport #35142)
@ruthra-kumar ruthra-kumar deleted the fix_bypass_check_in_customer_group branch June 14, 2023 16:02
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ruthra-kumar