Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internal transfer condition #35158

Conversation

rohitwaghchaure
Copy link
Collaborator

There are two scenarios which are as follows

Transfer between two branches of same company -> Delivery Note Required while making Purchase Receipt
Transfer between two branches of different company -> You can make Delivery Note and Purchase Receipt Individually

In the first case the rate in the purchase receipt should be same as delivery note and therefore reference of delivery note is required. Where as in the second case the rate of delivery note and purchase receipt might be different and therefore rate is not required.

Currently system is forcing to check reference in second case which is not required.

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #35158 (b5a2ccf) into develop (9aa6465) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35158      +/-   ##
===========================================
+ Coverage    63.69%   63.71%   +0.01%     
===========================================
  Files          813      813              
  Lines        60032    60100      +68     
===========================================
+ Hits         38239    38292      +53     
- Misses       21793    21808      +15     
Impacted Files Coverage Δ
...stock/doctype/purchase_receipt/purchase_receipt.py 92.69% <100.00%> (ø)
erpnext/stock/stock_ledger.py 90.27% <100.00%> (+0.06%) ⬆️

... and 12 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit 2bf7716 into frappe:develop May 4, 2023
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label May 4, 2023
rohitwaghchaure added a commit that referenced this pull request May 4, 2023
…-35158

fix: internal transfer condition (backport #35158)
rohitwaghchaure added a commit that referenced this pull request May 4, 2023
fix: internal transfer condition (backport #35158) (backport #35163)
rohitwaghchaure added a commit that referenced this pull request May 11, 2023
…-35158

fix: internal transfer condition (backport #35158)
rohitwaghchaure added a commit that referenced this pull request May 11, 2023
fix: internal transfer condition (backport #35158) (backport #35259)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests. stock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant