-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle empty FBs properly in TB and GL [v14] #35189
Merged
anandbaburajan
merged 1 commit into
frappe:version-14-hotfix
from
anandbaburajan:fb_empty_fix_v14
May 6, 2023
Merged
fix: handle empty FBs properly in TB and GL [v14] #35189
anandbaburajan
merged 1 commit into
frappe:version-14-hotfix
from
anandbaburajan:fb_empty_fix_v14
May 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbaburajan
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
May 6, 2023 10:43
@mergify backport version-14 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2023
fix: handle empty FBs properly in TB and GL (cherry picked from commit ed5f39c)
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2023
fix: handle empty FBs properly in TB and GL (cherry picked from commit ed5f39c)
anandbaburajan
added a commit
that referenced
this pull request
May 6, 2023
anandbaburajan
added a commit
that referenced
this pull request
May 6, 2023
anandbaburajan
pushed a commit
that referenced
this pull request
May 6, 2023
…backport #35192) (#35195) fix: handle empty FBs properly in TB and GL [v14] (backport #35189) (#35192) fix: handle empty FBs properly in TB and GL [v14] (#35189) fix: handle empty FBs properly in TB and GL (cherry picked from commit ed5f39c) Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com> (cherry picked from commit e2af66c) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 6, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 10, 2023
# [14.24.0](v14.23.4...v14.24.0) (2023-05-10) ### Bug Fixes * added search index to improve performance ([362003e](362003e)) * broken save on empty row existance ([c0f9ff4](c0f9ff4)) * bypass flag in Customer Group wasn't effective ([c73b76f](c73b76f)) * Changed type of column 'serial_no' in Stock Reconciliation to fix Data too long error ([709f94c](709f94c)) * child acc will inherit acc currency if explicitly specified ([72255fa](72255fa)) * enabling lead even after "Opportunity" created against it ([#34627](#34627)) ([5e98679](5e98679)) * error regarding accepted and supplier warehouse ([42f5888](42f5888)) * fetch default sales team on Quotation -> Sales Order creation ([f42225b](f42225b)) * handle empty FBs properly in TB and GL [v14] ([#35189](#35189)) ([ed5f39c](ed5f39c)) * incorrect fg item quantity in subcontracted PO ([5c38645](5c38645)) * internal transfer condition ([f5f4902](f5f4902)) * non manufacturing items/fixed asset items in BOM ([8133be4](8133be4)) * not allow to transfer excess materials against the job card ([b0c042d](b0c042d)) * over production percentage not considered in validation ([bf6e1b6](bf6e1b6)) * pick the in progress reposting entries first ([545f956](545f956)) ### Features * configuration to notify reposting errors to specific role ([33cd14f](33cd14f)) * reserve qty against production plan raw materials in BIN ([d1a9117](d1a9117))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35136 didn't handle finance books set to "", so fixed that.