Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Gross and Net Profit Report - incorrect calculation of totals #35320

Merged
merged 6 commits into from
May 25, 2023
Merged

fix: Gross and Net Profit Report - incorrect calculation of totals #35320

merged 6 commits into from
May 25, 2023

Conversation

akurungadam
Copy link
Contributor

closes #33249

Screenshots/GIFs

1 - Group node total

Before this -
before-1

After -
after-1

2 - Total for Gross Profit and Net Profit rows

Before
before-2

After
after-2

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 16, 2023
@ruthra-kumar ruthra-kumar self-assigned this May 17, 2023
@deepeshgarg007 deepeshgarg007 added the backport develop instructs mergify to frontport PR to develop branch label May 25, 2023
@deepeshgarg007 deepeshgarg007 merged commit 151b599 into frappe:version-14-hotfix May 25, 2023
@mergify mergify bot mentioned this pull request May 25, 2023
Merged
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@maveezmh
Copy link

maveezmh commented Jun 2, 2023

@deepeshgarg007 can backport to version-13 as well?

@rtdany10
Copy link
Contributor

rtdany10 commented Jun 8, 2023

@deepeshgarg007 @ruthra-kumar is it possible to backport this to v13 as well, please?

@rtdany10
Copy link
Contributor

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2023

backport version-13-hotfix

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@mergify mergify bot mentioned this pull request Jun 19, 2023
Merged
ruthra-kumar added a commit that referenced this pull request Jun 19, 2023
@ruthra-kumar
Merge pull request #35780 from frappe/mergify/bp/version-13-hotfix/pr…
af10d80 
…-35320

fix: Gross and Net Profit Report - incorrect calculation of totals (backport #35320)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees

@ruthra-kumar ruthra-kumar

Labels
backport develop instructs mergify to frontport PR to develop branch backport version-13-hotfix needs-tests This PR needs automated unit-tests. released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akurungadam @frappe-pr-bot @maveezmh @rtdany10 @ruthra-kumar @deepeshgarg007