Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tds incorrectly calculated for invoice that are below threshold (backport #35335) #35360

Merged
merged 2 commits into from
May 18, 2023
Merged

fix: tds incorrectly calculated for invoice that are below threshold (backport #35335) #35360

merged 2 commits into from
May 18, 2023

Commits on May 18, 2023

  1. fix: tds incorrectly calculated for invoice that are below threshold 

    Two purchase invoices for the same supplier, using different tax
withholding categories have this issue.

| Category | single | cumulative |
|----------+--------+------------|
| cat1     |    100 |        500 |
| cat2     |   1000 |       5000 |

1. PINV1 of net total: 105/- uses cat1. TDS is calculated as it
breached single threshold
2. PINV2 of net total: 200/- uses cat2. TDS incorrectly calculated as
PINV1 already has TDS calculated and 'consider_party_ledger_amount' is enabled.

(cherry picked from commit 84b7c1b)
    @ruthra-kumar @mergify
    ruthra-kumar authored and mergify[bot] committed May 18, 2023
    Configuration menu
    Copy the full SHA
    2e3f8e8 View commit details
    Browse the repository at this point in the history

  2. fix(test): cumulative threshold checks 

    (cherry picked from commit 132846b)
    @ruthra-kumar @mergify
    ruthra-kumar authored and mergify[bot] committed May 18, 2023
    Configuration menu
    Copy the full SHA
    d316955 View commit details
    Browse the repository at this point in the history