-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect POS Reserved Qty
in Stock Projected Qty
Report
#35437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-aga-r
requested review from
nextchamp-saqib,
ruthra-kumar,
rohitwaghchaure and
deepeshgarg007
May 27, 2023 06:43
s-aga-r
added
backport version-13-hotfix
backport version-14-hotfix
backport to version 14
and removed
needs-tests
This PR needs automated unit-tests.
labels
May 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #35437 +/- ##
========================================
Coverage 63.99% 63.99%
========================================
Files 815 815
Lines 60759 60762 +3
========================================
+ Hits 38882 38885 +3
Misses 21877 21877
|
This was referenced May 28, 2023
s-aga-r
added a commit
that referenced
this pull request
May 28, 2023
…-35437 fix: incorrect `POS Reserved Qty` in `Stock Projected Qty` Report (backport #35437)
s-aga-r
added
bug
and removed
backport version-13-hotfix
backport version-14-hotfix
backport to version 14
labels
May 29, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 31, 2023
# [13.51.0](v13.50.6...v13.51.0) (2023-05-31) ### Bug Fixes * force to do reposting for cancelled document ([0228933](0228933)) * **Gross Profit:** 'company' column is ambiguous in filter ([270eb1d](270eb1d)) * incorrect `POS Reserved Qty` in `Stock Projected Qty` Report ([#35437](#35437)) ([139a193](139a193)) * incorrect depr schedule and posting dates on selling of existing assets [v13] ([#35404](#35404)) ([20d3381](20d3381)) * monthly WDV depr schedule for existing assets [v13] ([#35461](#35461)) ([6f43829](6f43829)) * retention stock entry: grab conversion factor from source ([d8dd22a](d8dd22a)) ### Features * Allow ceil & floor functions in salary slip formulae ([#35475](#35475)) ([63fba9d](63fba9d))
This comment was marked as resolved.
This comment was marked as resolved.
vishdha
reviewed
Dec 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source / Ref: ISS-23-24-01015
Issue: The
Reserved for POS Transactions
shows incorrect qty in theStock Projected Qty
report. TheIs Return
filter is missing in theget_pos_reserved_qty
function.Steps to Replicate:
Stock Projected Qty
report for the respective Item and Warehouse.#32735