Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect POS Reserved Qty in Stock Projected Qty Report #35437

Merged
merged 2 commits into from
May 28, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented May 27, 2023

Source / Ref: ISS-23-24-01015

Issue: The Reserved for POS Transactions shows incorrect qty in the Stock Projected Qty report. The Is Return filter is missing in the get_pos_reserved_qty function.

Steps to Replicate:

  • Create POS Invoice.
  • Create Consolidated Sales Invoices.
  • Create a Return Against POS Invoice.
  • Check the Stock Projected Qty report for the respective Item and Warehouse.

#32735

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 27, 2023
@s-aga-r s-aga-r marked this pull request as ready for review May 27, 2023 06:43
@s-aga-r s-aga-r added backport version-13-hotfix backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels May 27, 2023
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #35437 (336ff5b) into develop (4099330) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35437   +/-   ##
========================================
  Coverage    63.99%   63.99%           
========================================
  Files          815      815           
  Lines        60759    60762    +3     
========================================
+ Hits         38882    38885    +3     
  Misses       21877    21877           
Impacted Files Coverage Δ
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 75.19% <100.00%> (+0.19%) ⬆️

@s-aga-r s-aga-r merged commit afd9098 into frappe:develop May 28, 2023
s-aga-r added a commit that referenced this pull request May 28, 2023
…-35437

fix: incorrect `POS Reserved Qty` in `Stock Projected Qty` Report (backport #35437)
deepeshgarg007 pushed a commit that referenced this pull request May 29, 2023
…5437)

* fix: incorrect `POS Reserved Qty` in `Stock Projected Qty` Report

(cherry picked from commit 027de41)

# Conflicts:
#	erpnext/accounts/doctype/pos_invoice/pos_invoice.py

* chore: `conflicts`

---------

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request May 31, 2023
# [13.51.0](v13.50.6...v13.51.0) (2023-05-31)

### Bug Fixes

* force to do reposting for cancelled document ([0228933](0228933))
* **Gross Profit:** 'company' column is ambiguous in filter ([270eb1d](270eb1d))
* incorrect `POS Reserved Qty` in `Stock Projected Qty` Report ([#35437](#35437)) ([139a193](139a193))
* incorrect depr schedule and posting dates on selling of existing assets [v13] ([#35404](#35404)) ([20d3381](20d3381))
* monthly WDV depr schedule for existing assets [v13] ([#35461](#35461)) ([6f43829](6f43829))
* retention stock entry: grab conversion factor from source ([d8dd22a](d8dd22a))

### Features

* Allow ceil & floor functions in salary slip formulae ([#35475](#35475)) ([63fba9d](63fba9d))
@vishdha

This comment was marked as resolved.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants