Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retention stock entry: grab conversion factor from source #35459

Merged
merged 3 commits into from
May 30, 2023
Merged

fix: retention stock entry: grab conversion factor from source #35459

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6954f53
fix: retention stock entry: grab conversion factor from source
marc-dll May 29, 2023
ed0c8ae
Merge branch 'develop' into FIX_retention_stock_entry_conversion_factor
s-aga-r May 30, 2023
91ca266
Merge branch 'develop' into FIX_retention_stock_entry_conversion_factor
s-aga-r May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion erpnext/stock/doctype/stock_entry/stock_entry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2398,7 +2398,7 @@ def move_sample_to_retention_warehouse(company, items):
"basic_rate": item.get("valuation_rate"),
"uom": item.get("uom"),
"stock_uom": item.get("stock_uom"),
"conversion_factor": 1.0,
"conversion_factor": item.get("conversion_factor") or 1.0,
"serial_no": sample_serial_nos,
"batch_no": item.get("batch_no"),
},
Expand Down