Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update Stock Reconciliation document while reposting #35481

Merged
merged 2 commits into from
Jun 1, 2023
Merged

fix: update Stock Reconciliation document while reposting #35481

merged 2 commits into from
Jun 1, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented May 30, 2023

Source/Ref: ISS-23-24-01138

Issue: The Stock Reconciliation document didn't get updated after reposting which results in different values in the document and ledgers.

Steps to Replicate:

  • Create Stock Reconciliation [1] to update the Qty or Valuation Rate.
  • Create a back-dated Stock Reconciliation with Posting Date before the Stock Reconciliation [1].
  • Complete the Repost Item Valuation.
  • Check the Stock Reconciliation [1] document and ledgers.

Stock Reconciliation [1] Stock Ledger
image

Stock Reconciliation [1] Accounting Ledger
image

Stock Reconciliation [1] Document - Before
image

Stock Reconciliation [1] Document - After
image

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels May 30, 2023
@s-aga-r s-aga-r added WIP and removed needs-tests This PR needs automated unit-tests. labels May 30, 2023
@s-aga-r s-aga-r removed the WIP label May 31, 2023
@s-aga-r s-aga-r marked this pull request as ready for review May 31, 2023 06:50
@s-aga-r s-aga-r added the backport version-14-hotfix backport to version 14 label Jun 1, 2023
@rohitwaghchaure rohitwaghchaure merged commit 90c79cb into frappe:version-14-hotfix Jun 1, 2023
@mergify mergify bot mentioned this pull request Jun 1, 2023
Closed
@s-aga-r s-aga-r added backport develop instructs mergify to frontport PR to develop branch and removed backport version-14-hotfix backport to version 14 labels Jun 1, 2023
@mergify mergify bot mentioned this pull request Jun 1, 2023
Merged
s-aga-r added a commit that referenced this pull request Jun 1, 2023
@s-aga-r
Merge pull request #35529 from frappe/mergify/bp/develop/pr-35481
13f427a 
fix: update `Stock Reconciliation` document while reposting (backport #35481)
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This was referenced Jun 15, 2023
Merged
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport develop instructs mergify to frontport PR to develop branch released stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-aga-r @frappe-pr-bot @rohitwaghchaure