Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added process loss in job card #35629

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Jun 9, 2023

Issue

If the quantity to manufacture is not same as completed qty in job card then system throw the error that "quantity to manufacture should be same as completed qty"

Screenshot 2023-06-09 at 10 38 07 PM

But what if there is process loss and qty has not produced as per plan?

Solution

To solve this problem, added provision to set process loss qty in the job card

Screenshot 2023-06-09 at 11 20 22 PM

If you're using the Routing and first operation has process loss then in the second operation you won't be able to produce more qty than first operation completed qty. If you tried produce more qty then system will throw below error

image

System will auto capture the Process Loss (from job cards) in the Manufacture Stock Entry
Screenshot 2023-06-09 at 11 27 28 PM

After completion of 9 quantity system won't allow to make further stock entries against the work order for 1 quantity because 1 quantity was process loss. (Fixed #34978)
Screenshot 2023-06-09 at 11 30 41 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #35629 (6458618) into develop (6201141) will increase coverage by 0.01%.
The diff coverage is 95.65%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35629      +/-   ##
===========================================
+ Coverage    63.93%   63.94%   +0.01%     
===========================================
  Files          812      812              
  Lines        61822    61850      +28     
===========================================
+ Hits         39523    39549      +26     
- Misses       22299    22301       +2     
Impacted Files Coverage Δ
...ext/manufacturing/doctype/work_order/work_order.py 80.41% <87.50%> (+0.08%) ⬆️
erpnext/manufacturing/doctype/job_card/job_card.py 73.00% <95.45%> (+0.77%) ⬆️
erpnext/stock/doctype/stock_entry/stock_entry.py 82.17% <100.00%> (-0.01%) ⬇️

@rohitwaghchaure rohitwaghchaure removed the needs-tests This PR needs automated unit-tests. label Jun 12, 2023
@rohitwaghchaure rohitwaghchaure merged commit 4ee08b9 into frappe:develop Jun 12, 2023
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label Jun 12, 2023
rohitwaghchaure added a commit that referenced this pull request Jun 13, 2023
…-35629

fix: added process loss in job card (backport #35629)
@precihole
Copy link

precihole commented Jul 29, 2023

Hello, @rohitwaghchaure

How to partially complete the job card. Like i have 10 qty in job card but i want to complete only for 5 but it set remaning qty as loss.
image

@goapaints
Copy link

@rohitwaghchaure , in multi-level BOM, when the above process Item is used, the qty required should be a proportion of (quantity to manufacture - process loss), else estimation will be less. If you agree, i will raise a bug.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V14 Process Loss should be considered as part of qty to manufacture in Work Order
3 participants