Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Index pick list field in stock entry and DN (backport #35738) #35742

Merged
merged 2 commits into from
Jun 17, 2023

Commits on Jun 16, 2023

  1. perf: Index pick list field in stock entry and DN (#35738)

    We check if pick list is created against them but there's no index so we
    end up reading entire table.
    
    ```
    +------+-------------+------------------+-------+---------------+----------+---------+------+--------+-----------+----------+------------+-------------+
    | id   | select_type | table            | type  | possible_keys | key      | key_len | ref  | rows   | r_rows    | filtered | r_filtered | Extra       |
    +------+-------------+------------------+-------+---------------+----------+---------+------+--------+-----------+----------+------------+-------------+
    |    1 | SIMPLE      | tabDelivery Note | index | NULL          | modified | 9       | NULL | 207015 | 348940.00 |   100.00 |       0.00 | Using where |
    +------+-------------+------------------+-------+---------------+----------+---------+------+--------+-----------+----------+------------+-------------+
    ```
    
    After
    
    ```
    +------+-------------+------------------+------+-----------------+-----------------+---------+-------+------+--------+----------+------------+------------------------------->
    | id   | select_type | table            | type | possible_keys   | key             | key_len | ref   | rows | r_rows | filtered | r_filtered | Extra                         >
    +------+-------------+------------------+------+-----------------+-----------------+---------+-------+------+--------+----------+------------+------------------------------->
    |    1 | SIMPLE      | tabDelivery Note | ref  | pick_list_index | pick_list_index | 563     | const | 1    | 0.00   |   100.00 |     100.00 | Using index condition; Using w>
    +------+-------------+------------------+------+-----------------+-----------------+---------+-------+------+--------+----------+------------+------------------------------->
    ```
    
    (cherry picked from commit 433489a)
    
    # Conflicts:
    #	erpnext/stock/doctype/delivery_note/delivery_note.json
    ankush authored and mergify[bot] committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    138462a View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. chore: conflict

    ankush committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    c614171 View commit details
    Browse the repository at this point in the history