Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect outstanding and total amount in reference table of payment entry #35868

Conversation

ruthra-kumar
Copy link
Member

  1. Make Sales Order/Invoice in foreign currency, but debit to company currency Debtors
  2. Create a Payment Entry, with Debtors as paid_from account
  3. Add [1] in reference table of payment entry
    outstanding_amount and total_amount are in transaction_currency, when it should have been in base_currency

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #35868 (9655d78) into develop (d1bccc8) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35868      +/-   ##
===========================================
- Coverage    64.28%   64.22%   -0.07%     
===========================================
  Files          811      811              
  Lines        62065    62108      +43     
===========================================
- Hits         39899    39887      -12     
- Misses       22166    22221      +55     
Impacted Files Coverage Δ
...xt/accounts/doctype/payment_entry/payment_entry.py 83.31% <100.00%> (ø)

... and 7 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit a90fe25 into frappe:develop Jun 25, 2023
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Jul 3, 2023
ruthra-kumar added a commit that referenced this pull request Jul 4, 2023
…-35868

fix: incorrect outstanding and total amount in reference table of payment entry (backport #35868)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant