perf: improve item wise register reports #35908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbaburajan
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
anandbaburajan
added
backport version-13-hotfix
backport develop
anandbaburajan
merged commit 33ee011
into
frappe:version-14-hotfix
9 of 10 checks passed
mergify bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
(cherry picked from commit 33ee011)
mergify bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
(cherry picked from commit 33ee011)
|
@mergify backport version-14 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
(cherry picked from commit 33ee011)
anandbaburajan
added a commit
that referenced
this pull request
Jun 28, 2023
perf: improve item wise register reports (backport #35908)
anandbaburajan
added a commit
that referenced
this pull request
Jun 28, 2023
anandbaburajan
added a commit
that referenced
this pull request
Jun 28, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
## [14.27.13](v14.27.12...v14.27.13) (2023-06-28) ### Performance Improvements * improve item wise register reports ([#35908](#35908)) ([189954e](189954e))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
# [14.28.0](v14.27.14...v14.28.0) (2023-06-28) ### Bug Fixes * asset capitalization ([#35832](#35832)) ([fb823b5](fb823b5)) * asset movement ([#35918](#35918)) ([e16c148](e16c148)) * delivery trip driver is only required on submit (backport [#35876](#35876)) ([#35893](#35893)) ([fc051d1](fc051d1)) * don't allow to make reposting entry for closing stock balance period ([e68b088](e68b088)) * filter parent warehouses not showing (backport [#35897](#35897)) ([#35899](#35899)) ([87ba196](87ba196)) * incorrect cost center error in bank reconciliation ([cacb0f6](cacb0f6)) * issue of asset value_after_depreciation field getting updated twice if workflow is enabled in Journal Entry (backport [#35821](#35821)) ([#35827](#35827)) ([20f2bef](20f2bef)) * make credit note and debit note exclusive ([#35781](#35781)) ([fafb46e](fafb46e)) * multiple Work Orders agaist same production plan ([8ddfc34](8ddfc34)) * no permission for accounts settings on payment reconciliation ([200ddbf](200ddbf)) * Payment Term must be mandatory if `Allocate Payment based on ..` is checked ([#35798](#35798)) ([3dd3935](3dd3935)) * POS Closing Entry load all invoices with one request on save ([#35819](#35819)) ([8ecca2a](8ecca2a)) * reconcile invoice against credit note. ([#35604](#35604)) ([5c388a1](5c388a1)) * Remove special treatment for P&L Accounts ([#35602](#35602)) ([b023448](b023448)) * Set Asset cost center default as PR or PI Item Cost Center while auto creating ([#35844](#35844)) ([4a7d75b](4a7d75b)) * show non-depreciable assets in fixed asset register ([#35858](#35858)) ([42d0944](42d0944)) * TDS amount calculation post LDC breach ([851b887](851b887)) * use correct fieldname for purchase receipt column in item_wise_purchase_register report ([#35828](#35828)) ([8f13b48](8f13b48)) * **ux:** PO Get Items From Open Material Requests (backport [#35894](#35894)) ([#35895](#35895)) ([2ef2057](2ef2057)) ### Features * Auto set Party in Bank Transaction ([#34675](#34675)) ([d53b197](d53b197)) * Provision to send Accounts Receivable Reports using Process SOA ([#35789](#35789)) ([21d560c](21d560c)), closes [#35707](#35707) ### Performance Improvements * improve item wise register reports ([#35908](#35908)) ([33ee011](33ee011))
|
🎉 This PR is included in version 14.28.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
## [13.51.7](v13.51.6...v13.51.7) (2023-06-28) ### Bug Fixes * asset movement (backport [#35918](#35918)) ([#35924](#35924)) ([0bcd047](0bcd047)) * employee link fields in payroll reports ([#619](#619)) ([#35845](#35845)) ([6c4dff3](6c4dff3)) * filter parent warehouses not showing (backport [#35897](#35897)) ([#35900](#35900)) ([bcfd770](bcfd770)) * frappe.exceptions.DoesNotExistError: DocType KSA VAT Setting ([#35797](#35797)) ([3785fe6](3785fe6)), closes [#35795](#35795) * show non-depreciable assets in fixed asset register (backport [#35858](#35858)) ([#35861](#35861)) ([2e2c319](2e2c319)) * TDS amount calculation post LDC breach ([#35886](#35886)) ([4dd088c](4dd088c)) * use correct fieldname for purchase receipt column in item_wise_purchase_register report (backport [#35828](#35828)) ([#35848](#35848)) ([de529f0](de529f0)) * **ux:** PO Get Items From Open Material Requests (backport [#35894](#35894)) ([#35896](#35896)) ([12b6257](12b6257)) ### Performance Improvements * improve item wise register reports (backport [#35908](#35908)) ([#35912](#35912)) ([4134459](4134459))
deepeshgarg007
added a commit
that referenced
this pull request
Jul 9, 2023
deepeshgarg007
added a commit
that referenced
this pull request
Jul 9, 2023
…-13-hotfix/pr-35908 Revert "perf: improve item wise register reports (backport #35908)"
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 9, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
## [13.52.4](v13.52.3...v13.52.4) (2023-07-11) ### Bug Fixes * also check on_hold ([#35910](#35910)) ([5aa02b8](5aa02b8)) * circular dependency during reposting causing timeout error ([ba69be1](ba69be1)) * **Employee Advance:** check if return amount is set before validating ([#36080](#36080)) ([beaf13e](beaf13e)) * error messages while evaluating formulas and handle line boundaries ([#35989](#35989)) ([4af57a7](4af57a7)) * gst_hsn_code is ambiguous on gst reports ([3a00052](3a00052)) * incorrect status in MR created from PP (backport [#36085](#36085)) ([#36087](#36087)) ([e05bb10](e05bb10)) * payment entry `voucher_type` error ([#35779](#35779)) ([9c3ec41](9c3ec41)) * **Payment Entry:** compare rounded amount ([#36011](#36011)) ([b04c190](b04c190)) * precision causing outstanding issue on partly paid invoices ([#36030](#36030)) ([cf3ec93](cf3ec93)) * single column indexes ([#32425](#32425)) ([53f7764](53f7764)) ### Reverts * Revert "perf: improve item wise register reports (backport #35908) (#35912)" ([b992366](b992366)), closes [#35908](#35908) [#35912](#35912)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the
item_wise_sales_registeranditem_wise_purchase_registerby removing the unnecessaryget_item_detailsfunction (and adding the same logic to the query in theget_itemsfunction) and memoized the values of scrubbed tax fields.