fix: project filtering based on company in P&L Report #35943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #35943 +/- ##
==========================================
Coverage 64.15% 64.15%
==========================================
Files 813 785 -28
Lines 62217 60485 -1732
==========================================
- Hits 39914 38803 -1111
+ Misses 22303 21682 -621 |
deepeshgarg007
pushed a commit
that referenced
this pull request
Jul 1, 2023
* fix: project filtering in P&L Report (cherry picked from commit 904ca74) * fix: show projects with no company value set (cherry picked from commit ce252a0) * fix: make company field mandatory in project doctype (cherry picked from commit 84d4888) --------- Co-authored-by: Gursheen Anand <gursheen@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
# [14.29.0](v14.28.1...v14.29.0) (2023-07-05) ### Bug Fixes * Expense Account filter in Sales Invoice ([#35944](#35944)) ([a485e4e](a485e4e)) * get base grand total while pulling reference details in PE ([2e2c23a](2e2c23a)) * handle loan_repayment's posting_date datetime in bank_clearance_summary report ([#36004](#36004)) ([937e1fb](937e1fb)) * Netherlands - Grootboekschema COA structure ([#35991](#35991)) ([13f3ebf](13f3ebf)) * project filtering based on company in P&L Report ([#35943](#35943)) ([8de1d86](8de1d86)) * remove debug flag from sql ([646440f](646440f)) * reposting has not changed valuation rate ([c0c693d](c0c693d)) * Update no copy for received_qty field ([#35965](#35965)) ([c330f47](c330f47)) ### Features * **accounts:** standardize additional columns implementation for sales/purchase reports ([#36000](#36000)) ([47c6d90](47c6d90)) * add method for ordered quantity in supplier scorecard (backport [#35930](#35930)) ([#35968](#35968)) ([a974091](a974091)) * add voucher-wise balance report logic ([6842902](6842902)) * allow the partial return of components against SCO (backport [#35935](#35935)) ([#35938](#35938)) ([6f50ad6](6f50ad6))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added company specific Project Filtering in P&L report.
Previously the P&L Report filter for Project showed projects for all companies instead of for the selected company.
Project belonging to company - Twiga
Project filter shows the project even though another company is selected.
Project filter now shows only projects for selected company.