Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect reposting causing stock adjustment entry #35955

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

  1. Created Purchase Receipt for the item A with 100 Qty and Rate as 273.45 in the warehouse Stores
  2. Created return entry against above purchase receipt for 2 quantity
  3. Created Stock Transfer Entry from "Stores" to "Warehouse A" for 20 Qty
  4. Created Stock Transfer Entry from "Stores" to "Warehouse B" for 20 Qty
  5. Created Stock Transfer Entry from "Stores" to "Warehouse C" for 20 Qty
  6. Created Stock Transfer Entry from "Warehouse A" to "Stores" for 20 Qty (This entry has an issue)
  7. After that created Backdated Landed Cost Voucher against the Purchase Receipt (created at point no 1)
  8. In the landed cost voucher reduced the cost from 273.45 to 250
  9. System has auto created Repost Item Valuation entry after the landed cost voucher
  10. Then checked the Stock Ledger Entries and found that the system has changed the valuation rate from 273.45 to 250 for all future stock ledgers except for the Stock Entry which was created at point no 6 ("Warehouse A" to "Stores")
  11. Because of this system has created Stock Adjustment gl entries against the "Material Transfer" entry

Stock Entry has no Stock Difference
Screenshot 2023-07-01 at 9 20 51 AM

But still has Stock Adjustment Entry
Screenshot 2023-07-01 at 9 20 44 AM

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Jul 1, 2023
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-incorrect-valuation-rate branch 3 times, most recently from 22f343c to 873aa8a Compare July 1, 2023 18:07
@rohitwaghchaure rohitwaghchaure merged commit c3eab84 into frappe:version-14-hotfix Jul 2, 2023
@rohitwaghchaure rohitwaghchaure added backport develop instructs mergify to frontport PR to develop branch and removed needs-tests This PR needs automated unit-tests. labels Jul 2, 2023
@frappe frappe deleted a comment from mergify bot Jul 2, 2023
@rohitwaghchaure
Copy link
Collaborator Author

@Mergifyio backport version-14

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2023

backport version-14

✅ Backports have been created

rohitwaghchaure added a commit that referenced this pull request Jul 2, 2023
fix: incorrect reposting causing stock adjustment entry (backport #35955)
rohitwaghchaure added a commit that referenced this pull request Jul 2, 2023
fix: incorrect reposting causing stock adjustment entry (backport #35955)
rohitwaghchaure added a commit that referenced this pull request Jul 3, 2023
…-35955

fix: incorrect reposting causing stock adjustment entry (backport #35955)
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport develop instructs mergify to frontport PR to develop branch backport version-13-hotfix released stock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants