Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: send SLA doctypes in boot #36150

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Jul 16, 2023

This request is fired on every load, data rarely if ever changes though.

fix:

  • send SLA doctypes via boot, eliminate the request.
  • cache SLA doctypes

This request is fired on every load, data rarely if ever changes though.
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 16, 2023
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Jul 16, 2023
@ankush ankush enabled auto-merge July 16, 2023 06:14
@ankush ankush added the backport version-14-hotfix backport to version 14 label Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #36150 (bd9ef74) into develop (04400eb) will decrease coverage by 0.06%.
The diff coverage is 62.12%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36150      +/-   ##
===========================================
- Coverage    64.21%   64.16%   -0.06%     
===========================================
  Files          785      782       -3     
  Lines        60681    60600      -81     
===========================================
- Hits         38965    38882      -83     
- Misses       21716    21718       +2     
Impacted Files Coverage Δ
erpnext/accounts/report/financial_statements.py 31.07% <ø> (+0.11%) ⬆️
...ext/accounts/report/trial_balance/trial_balance.py 0.00% <ø> (ø)
erpnext/telephony/doctype/call_log/call_log.py 37.62% <6.66%> (-42.77%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 63.97% <25.00%> (ø)
erpnext/setup/doctype/holiday_list/holiday_list.py 77.17% <81.57%> (+35.63%) ⬆️
...service_level_agreement/service_level_agreement.py 83.18% <85.71%> (+0.03%) ⬆️
erpnext/hooks.py 100.00% <100.00%> (ø)
...cturing/doctype/production_plan/production_plan.py 80.20% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ankush ankush merged commit c545399 into frappe:develop Jul 16, 2023
@ankush ankush deleted the perf/desk_requests branch July 16, 2023 07:00
ankush added a commit that referenced this pull request Jul 16, 2023
…-36150

perf: send SLA doctypes in boot (backport #36150)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant