feat: Reallow customizing company abbreviation on setup. #36412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosue
force-pushed
the
Custom_Abbr_On_Setup
branch
from
cc4dceb
to
bc8d05d
Compare
bosue
changed the title
|
Resolves #36394. |
|
Nice, thank you, @deepeshgarg007, for merging my first successful PR here! 😀 |
This was referenced Aug 3, 2023
|
@Mergifyio backport version-14-hotfix |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The company abbreviation field was only removed earlier this year, in January, as part of a larger effort at simplifying the setup wizard: #33675.
While many if not most settings don‘t have to be set this early, thus the cleanup greatly improved simplicity for first time users, the company abbreviation field is a different beast.
It cannot be changed later as per #27766 and is hardcoded into the CoA and several other places during setup.
In the long term we should avoid hardcoding anything anywhere, but for now we need to reinstate this one field in the setup wizard.
Enclosed PR accomplishes this efficiently while minimizing noise, clutter. The installing user who may currently feel disempowered by an automatism that doesn’t fit their needs, is handed back control.
Example with the PR applied: obviously it‘s “NASA,” not “NAASA.”
RPReplay_Final1690740937.mov
no-docs