-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: better cost center validation for assets #36477
Merged
anandbaburajan
merged 1 commit into
frappe:develop
from
anandbaburajan:asset_cost_center_validation
Aug 3, 2023
Merged
chore: better cost center validation for assets #36477
anandbaburajan
merged 1 commit into
frappe:develop
from
anandbaburajan:asset_cost_center_validation
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbaburajan
added
backport version-13-hotfix
backport develop
instructs mergify to frontport PR to develop branch
labels
Aug 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #36477 +/- ##
===========================================
- Coverage 64.54% 64.54% -0.01%
===========================================
Files 787 787
Lines 61173 61176 +3
===========================================
+ Hits 39485 39486 +1
- Misses 21688 21690 +2
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
(cherry picked from commit 38a612c)
anandbaburajan
removed
the
backport develop
instructs mergify to frontport PR to develop branch
label
Aug 3, 2023
@mergify backport version-14-hotfix |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
(cherry picked from commit 38a612c)
anandbaburajan
added a commit
that referenced
this pull request
Aug 3, 2023
anandbaburajan
added a commit
that referenced
this pull request
Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding better cost center validation on asset creation since some users were only getting to know about correct cost center requirements only when the depreciations were posted.