Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better cost center validation for assets #36477

Merged
merged 1 commit into from
Aug 3, 2023
Merged

chore: better cost center validation for assets #36477

merged 1 commit into from
Aug 3, 2023

Conversation

anandbaburajan
Copy link
Contributor

Adding better cost center validation on asset creation since some users were only getting to know about correct cost center requirements only when the depreciations were posted.

@anandbaburajan anandbaburajan added backport version-13-hotfix backport develop instructs mergify to frontport PR to develop branch labels Aug 3, 2023
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #36477 (e4047dd) into develop (27ebf14) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36477      +/-   ##
===========================================
- Coverage    64.54%   64.54%   -0.01%     
===========================================
  Files          787      787              
  Lines        61173    61176       +3     
===========================================
+ Hits         39485    39486       +1     
- Misses       21688    21690       +2     
Files Changed Coverage Δ
erpnext/assets/doctype/asset/asset.py 79.57% <75.00%> (-0.27%) ⬇️

... and 2 files with indirect coverage changes

@anandbaburajan anandbaburajan merged commit 38a612c into frappe:develop Aug 3, 2023
13 checks passed
mergify bot pushed a commit that referenced this pull request Aug 3, 2023
@anandbaburajan anandbaburajan removed the backport develop instructs mergify to frontport PR to develop branch label Aug 3, 2023
@anandbaburajan
Copy link
Contributor Author

@mergify backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2023

backport version-14-hotfix

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 3, 2023
anandbaburajan added a commit that referenced this pull request Aug 3, 2023
…6479)

chore: better cost center validation for assets (#36477)

(cherry picked from commit 38a612c)

Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
anandbaburajan added a commit that referenced this pull request Aug 3, 2023
…6478)

chore: better cost center validation for assets (#36477)

(cherry picked from commit 38a612c)

Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-13-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant