Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: POS runtime effect #36492

Merged

Conversation

RitvikSardana
Copy link
Member

Issue:

In POS whenever we return an item it is not reflected in the item quantity till we close the POS, because of this the returned item can't be used in the current POS.

Solution:
The item qty is updated as soon as it is returned.

@RitvikSardana RitvikSardana self-assigned this Aug 4, 2023
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 4, 2023
@rtdany10
Copy link
Contributor

rtdany10 commented Aug 5, 2023

Does it update the stock real time for all cases or only on returns?
Also there is a print statement in the code.

@RitvikSardana
Copy link
Member Author

@rtdany10

the stock is updated both times
when it is sold and when it is returned

@deepeshgarg007
Copy link
Member

@rtdany10 This is not for real-time stock updation. This is to handle the return stock item where they will be readily available to be sold again unlike earlier where they were available only after POS Closing

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #36492 (0d95fc0) into develop (10529e1) will increase coverage by 0.28%.
Report is 167 commits behind head on develop.
The diff coverage is 45.63%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36492      +/-   ##
===========================================
+ Coverage    64.54%   64.83%   +0.28%     
===========================================
  Files          787      792       +5     
  Lines        61176    61800     +624     
===========================================
+ Hits         39486    40065     +579     
- Misses       21690    21735      +45     
Files Changed Coverage Δ
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 73.27% <ø> (ø)
...ype/pos_invoice_merge_log/pos_invoice_merge_log.py 79.80% <ø> (ø)
...counts/report/accounts_payable/accounts_payable.py 100.00% <ø> (ø)
...counts_payable_summary/accounts_payable_summary.py 0.00% <ø> (ø)
..._receivable_summary/accounts_receivable_summary.py 0.00% <0.00%> (ø)
...counts/report/financial_ratios/financial_ratios.py 0.00% <0.00%> (ø)
erpnext/crm/doctype/lead/lead.py 68.03% <ø> (ø)
erpnext/accounts/party.py 77.40% <18.18%> (-0.76%) ⬇️
erpnext/accounts/doctype/account/account.py 73.18% <57.14%> (-0.42%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 71.11% <58.18%> (-1.56%) ⬇️
... and 11 more

... and 34 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Aug 17, 2023
@deepeshgarg007 deepeshgarg007 merged commit 98adfb4 into frappe:develop Aug 17, 2023
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants