Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RFQ): make "update password" and "submit quotation" buttons the same size #36667

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix(RFQ): make "update password" and "submit quotation" buttons the same size #36667

merged 1 commit into from
Aug 17, 2023

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Aug 15, 2023 •
edited
Loading

Related (but not dependent) PR: frappe/frappe#22067

@barredterra barredterra added the backport version-14-hotfix backport to version 14 label Aug 15, 2023
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 15, 2023
@barredterra barredterra changed the title fix(RFQ): button styling fix(RFQ): make "update password" and "submit quotation" buttons the same size Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #36667 (03e3eb3) into develop (45662fa) will not change coverage.
Report is 14 commits behind head on develop.
The diff coverage is 42.46%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #36667   +/-   ##
========================================
  Coverage    64.82%   64.82%           
========================================
  Files          792      792           
  Lines        61798    61798           
========================================
  Hits         40063    40063           
  Misses       21735    21735
Files Changed Coverage Δ
...tax_withholding_details/tax_withholding_details.py 0.00% <0.00%> (ø)
...tds_computation_summary/tds_computation_summary.py 0.00% <0.00%> (ø)
...xt/assets/doctype/asset_category/asset_category.py 87.09% <ø> (ø)
...ype/request_for_quotation/request_for_quotation.py 55.70% <ø> (ø)
erpnext/projects/report/billing_summary.py 0.00% <0.00%> (ø)
...ccounts/doctype/loyalty_program/loyalty_program.py 75.60% <50.00%> (ø)
...x_withholding_category/tax_withholding_category.py 93.48% <100.00%> (ø)
erpnext/controllers/status_updater.py 88.42% <100.00%> (ø)
erpnext/setup/demo.py 94.11% <100.00%> (ø)

@s-aga-r s-aga-r merged commit 552bbb1 into frappe:develop Aug 17, 2023
16 checks passed
@mergify mergify bot mentioned this pull request Aug 17, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 17, 2023
@barredterra @mergify
fix(RFQ): make "update password" and "submit quotation" buttons the s…
06e93ce 
…ame size (#36667)

fix(RFQ): button styling

(cherry picked from commit 552bbb1)

# Conflicts:
#	erpnext/buying/doctype/request_for_quotation/request_for_quotation.py
@barredterra barredterra deleted the rfq-button-styling branch August 17, 2023 07:41
barredterra added a commit that referenced this pull request Aug 17, 2023
@barredterra
fix(RFQ): make "update password" and "submit quotation" buttons the s…
1c9799e 
…ame size (#36667)

fix(RFQ): button styling
s-aga-r pushed a commit that referenced this pull request Aug 17, 2023
@mergify @barredterra
fix(RFQ): make "update password" and "submit quotation" buttons the s…
36147ec 
…ame size (backport #36667) (#36686)

fix(RFQ): make "update password" and "submit quotation" buttons the same size (#36667)

fix(RFQ): button styling

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 23, 2023
@frappe-bot
chore(release): Bumped to Version 14.36.0
d1b2ce3 
# [14.36.0](v14.35.2...v14.36.0) (2023-08-23)

### Bug Fixes

* Accounts Payable Currency bug ([94612b9](94612b9))
* Add company filters for account ([e62ffa9](e62ffa9))
* add missing items labels back ([#36737](#36737)) ([3634e80](3634e80))
* broken advance field in Accounts Receivable summary rpt ([296a4d7](296a4d7))
* broken consolidated report due to finance book filter ([5bd2a09](5bd2a09))
* check tax and charges if it is passed ([1f76c69](1f76c69))
* clear dimension defaults after test ([2a467a9](2a467a9))
* dict value for dimension for gl entries defined without the dimension ([11ba553](11ba553))
* dimension name in remark ([01ae513](01ae513))
* divide offsetting amount for multiple dimensions ([1269f2d](1269f2d))
* divide offsetting amount only when account exists ([2c8c3a0](2c8c3a0))
* Document Name link validation in Bank Reconciliation Tool ([#36495](#36495)) ([83cbc1b](83cbc1b)), closes [#35540](#35540) [#35540](#35540)
* don't throw if item does not have default BOM (backport [#36709](#36709)) ([#36734](#36734)) ([e1bd9a7](e1bd9a7))
* duplicate acc dimension in test ([cdb66bf](cdb66bf))
* fetch acc dimensions correctly when fieldname is different from name ([7ac35b4](7ac35b4))
* fetch accounting dimension details specific to company ([c1f1a21](c1f1a21))
* include gain/loss journal in AR/AP reports ([4606079](4606079))
* incorrect gl balance on multi company setup ([cb9aad3](cb9aad3))
* incorrect schedule in asset value adjustment ([#36725](#36725)) ([a0575ed](a0575ed))
* make offsetting entry for acc dimensions ([3198f26](3198f26))
* make offsetting entry for all doctypes ([f578c32](f578c32))
* mode of payment fetched from pos profile company in POS ([c74a414](c74a414))
* not able to make stock entry ([#36759](#36759)) ([873ee38](873ee38))
* Procurement Tracker report not showing material request items ([#36768](#36768)) ([6a9935c](6a9935c))
* reset dimension defaults when company changedin test ([37ef6e9](37ef6e9))
* **RFQ:** make "update password" and "submit quotation" buttons the same size (backport [#36667](#36667)) ([#36686](#36686)) ([36147ec](36147ec))
* timeout error coming during reposting ([#36715](#36715)) ([620b21f](620b21f))
* **ux:** change batch selection message to alert (backport [#36500](#36500)) ([#36697](#36697)) ([0a4947a](0a4947a))
* **UX:** Ignore prepared report ([3e23e1f](3e23e1f))

### Features

* **RFQ:** make email message fully configurable (backport [#36353](#36353)) ([#36531](#36531)) ([c308bd5](c308bd5))
* Tick on checkbox to include draft timesheets (backport [#36577](#36577)) ([#36640](#36640)) ([9668615](9668615))
* utility to repost accounting ledgers without cancellation ([#36469](#36469)) ([f8d6fe6](f8d6fe6))

### Performance Improvements

* pull latest details only for referenced vouchers ([47345e8](47345e8))
@commit-lint commit-lint bot mentioned this pull request Sep 27, 2023
Merged
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-aga-r s-aga-r s-aga-r approved these changes

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barredterra @s-aga-r