Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check tax and charges if it is passed #36685

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

shariquerik
Copy link
Member

@shariquerik shariquerik commented Aug 17, 2023

While creating a Sales Invoice through API we get the correct response but along with that we also get exc_type: DoesNotExistError which is caused by calling get_cached_doc where taxes_and_charges is None

{
"exc_type": "DoesNotExistError",
"message": {
	"success": "Your Sales Invoice has been received.",
	"sales_invoice": [
		"ACC-SINV-2023-00014"
		]
	}
}

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #36685 (21c1141) into develop (539cfd0) will increase coverage by 0.04%.
Report is 40 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36685      +/-   ##
===========================================
+ Coverage    64.77%   64.82%   +0.04%     
===========================================
  Files          792      792              
  Lines        61779    61803      +24     
===========================================
+ Hits         40018    40064      +46     
+ Misses       21761    21739      -22     
Files Changed Coverage Δ
erpnext/accounts/report/financial_statements.py 80.42% <ø> (ø)
...xt/accounts/doctype/payment_entry/payment_entry.py 83.50% <100.00%> (-0.30%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 71.11% <100.00%> (+0.05%) ⬆️
erpnext/controllers/accounts_controller.py 86.11% <100.00%> (ø)

... and 11 files with indirect coverage changes

@shariquerik shariquerik added the backport version-14-hotfix backport to version 14 label Aug 17, 2023
@shariquerik shariquerik merged commit 5d9dde9 into frappe:develop Aug 17, 2023
13 checks passed
@shariquerik shariquerik removed the needs-tests This PR needs automated unit-tests. label Aug 17, 2023
shariquerik added a commit that referenced this pull request Aug 17, 2023
…-36685

fix: check tax and charges if it is passed (backport #36685)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant