Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mode of payment fetched from pos profile company in POS #36696

Conversation

RitvikSardana
Copy link
Contributor

Issue:
In a multi company setup where each company has one or more pos profiles, when setting mode of payments for the pos profile, these are fetched for the default company instead of the company for each pos profile.

Reason:
before the pos profile company was set, we were throwing the error.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #36696 (1bdd43d) into develop (d138948) will increase coverage by 0.10%.
Report is 89 commits behind head on develop.
The diff coverage is 80.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36696      +/-   ##
===========================================
+ Coverage    64.72%   64.82%   +0.10%     
===========================================
  Files          791      792       +1     
  Lines        61633    61819     +186     
===========================================
+ Hits         39892    40077     +185     
- Misses       21741    21742       +1     
Files Changed Coverage Δ
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 73.37% <80.00%> (+0.09%) ⬆️

... and 22 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Aug 20, 2023
@deepeshgarg007 deepeshgarg007 merged commit ddd929e into frappe:develop Aug 20, 2023
14 checks passed
deepeshgarg007 added a commit that referenced this pull request Aug 20, 2023
…-36696

fix: mode of payment fetched from pos profile company in POS (#36696)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In multi company setup, POS mode of payment is fetched against default company only
2 participants