Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken consolidated report due to finance book filter #36710

Conversation

ruthra-kumar
Copy link
Member

Consolidated Financial Statement reported empty page due to incorrect filter on finance book

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #36710 (96847db) into develop (8601e5b) will increase coverage by 0.12%.
Report is 25 commits behind head on develop.
The diff coverage is 80.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36710      +/-   ##
===========================================
+ Coverage    64.82%   64.95%   +0.12%     
===========================================
  Files          792      792              
  Lines        61798    61821      +23     
===========================================
+ Hits         40063    40153      +90     
+ Misses       21735    21668      -67     
Files Changed Coverage Δ
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 73.27% <ø> (ø)
...ype/pos_invoice_merge_log/pos_invoice_merge_log.py 79.80% <ø> (ø)
erpnext/accounts/utils.py 73.98% <ø> (ø)
...cial_statement/consolidated_financial_statement.py 89.76% <50.00%> (+14.61%) ⬆️
...xt/accounts/doctype/payment_entry/payment_entry.py 83.50% <87.50%> (-0.22%) ⬇️
...serial_and_batch_bundle/serial_and_batch_bundle.py 71.15% <100.00%> (-0.06%) ⬇️

... and 6 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit a34cb8a into frappe:develop Aug 18, 2023
14 checks passed
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Aug 18, 2023
deepeshgarg007 added a commit that referenced this pull request Aug 19, 2023
…-36710

fix: broken consolidated report due to finance book filter (#36710)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant