Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken advance field in Accounts Receivable summary rpt #36727

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Aug 21, 2023

Advance amount field in Accounts Receivable Summary wasn't getting populated. This is fixed by Querying Payment Ledger for unallocated Advances.

Todo:

  • Add Tests

before:
before

after:
after

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #36727 (0dc5e5c) into develop (8601e5b) will increase coverage by 0.12%.
Report is 38 commits behind head on develop.
The diff coverage is 75.00%.

❗ Current head 0dc5e5c differs from pull request most recent head af52f21. Consider uploading reports for the commit af52f21 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36727      +/-   ##
===========================================
+ Coverage    64.82%   64.95%   +0.12%     
===========================================
  Files          792      792              
  Lines        61798    61826      +28     
===========================================
+ Hits         40063    40157      +94     
+ Misses       21735    21669      -66     
Files Changed Coverage Δ
...ype/pos_invoice_merge_log/pos_invoice_merge_log.py 79.80% <ø> (ø)
..._receivable_summary/accounts_receivable_summary.py 0.00% <ø> (ø)
erpnext/accounts/utils.py 73.98% <ø> (ø)
erpnext/accounts/party.py 78.01% <14.28%> (+0.60%) ⬆️
...xt/accounts/doctype/payment_entry/payment_entry.py 83.50% <87.50%> (-0.22%) ⬇️
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 73.37% <100.00%> (+0.09%) ⬆️
...serial_and_batch_bundle/serial_and_batch_bundle.py 71.15% <100.00%> (-0.06%) ⬇️

... and 8 files with indirect coverage changes

@ruthra-kumar ruthra-kumar force-pushed the fix_broken_advance_field_in_ar_summary_rpt branch from 6a04f02 to af52f21 Compare August 21, 2023 12:27
@ruthra-kumar ruthra-kumar merged commit a4ff76c into frappe:develop Aug 21, 2023
10 of 11 checks passed
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Aug 21, 2023
ruthra-kumar added a commit that referenced this pull request Aug 22, 2023
…-36727

fix: broken advance field in Accounts Receivable summary rpt (backport #36727)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant