fix: invalid gain/loss JE created on base currency Expense Claim #36940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #36940 +/- ##
===========================================
+ Coverage 65.42% 65.55% +0.13%
===========================================
Files 794 796 +2
Lines 62194 62717 +523
===========================================
+ Hits 40690 41114 +424
- Misses 21504 21603 +99
|
ruthra-kumar
added a commit
that referenced
this pull request
Sep 4, 2023
…-36940 fix: invalid gain/loss JE created on base currency Expense Claim (backport #36940)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
exchange_rateof individual reference is unset, make it1. If left unset,exchange_gain_lossis calculated leading to an incorrect JE being posted.part of: frappe/hrms#848