Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't set from warehouse for purchase material request #37132

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: don't set from warehouse for purchase material request #37132

merged 1 commit into from
Sep 18, 2023

Conversation

rohitwaghchaure
Copy link
Collaborator

  1. Create Production Plan and get Raw Materials for Transfer
  2. System will add raw materials with From Warehouse (For Material Transfer)
  3. Change the Material Request type from Material Transfer to Purchase
  4. Save and Submit the Production Plan
  5. Create the MR and PO
  6. You will notice that on the PO from warehouse has set even though it's not an Internal Transfer entry.
  7. After point 3, system should remove the From Warehouse for the Material Request type Purchase.

@rohitwaghchaure rohitwaghchaure merged commit e62b783 into frappe:version-14-hotfix Sep 18, 2023
11 checks passed
@rohitwaghchaure rohitwaghchaure added the backport develop instructs mergify to frontport PR to develop branch label Sep 18, 2023
mergify bot pushed a commit that referenced this pull request Sep 18, 2023
@rohitwaghchaure @mergify
fix: don't set from warehouse for purchase material request (#37132)
9483f1a 
(cherry picked from commit e62b783)
@mergify mergify bot mentioned this pull request Sep 18, 2023
Merged
rohitwaghchaure added a commit that referenced this pull request Sep 18, 2023
@mergify @rohitwaghchaure
fix: don't set from warehouse for purchase material request (backport #…
195de14 
…37132) (#37134)

fix: don't set from warehouse for purchase material request (#37132)

(cherry picked from commit e62b783)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Sep 20, 2023
@frappe-bot
chore(release): Bumped to Version 14.40.0
2713925 
# [14.40.0](v14.39.0...v14.40.0) (2023-09-20)

### Bug Fixes

* + btn not appearing for delivery note connection (backport [#36980](#36980)) ([#37070](#37070)) ([c2a0c1e](c2a0c1e))
* accepted warehouse and rejected warehouse can't be same (backport [#36973](#36973)) ([#37071](#37071)) ([b56c9b9](b56c9b9))
* after applying coupon code, field in_words not updated ([#37133](#37133)) ([1cb8c64](1cb8c64))
* Apply dimension filter, irrespective of dimesion columns ([9bc44a3](9bc44a3))
* asset validation misfire on debit notes ([b33db6c](b33db6c))
* company wise deferred accounting fields in item ([#37023](#37023)) ([13aaff3](13aaff3))
* Don't allow merging accounts with different currency ([#37074](#37074)) ([c41cb39](c41cb39))
* don't set from warehouse for purchase material request ([#37132](#37132)) ([e62b783](e62b783))
* Duplicate Serial Nos validation in POS ([#36927](#36927)) ([366325c](366325c))
* fetch logic for repay_from_salary in loan_repayment [v14] ([#37135](#37135)) ([480a0ca](480a0ca))
* ignore user permissions for `Source Warehouse` in MR (backport [#37102](#37102)) ([#37110](#37110)) ([727dcc5](727dcc5))
* incorrect stock ledger entries in DN (backport [#36944](#36944)) ([#37066](#37066)) ([699ad80](699ad80))
* packed item using expired price ([413b40f](413b40f))
* POS opening Issue if Product Bundle is available ([#37138](#37138)) ([af05864](af05864))
* precision issue and column name ([#37073](#37073)) ([f2395a9](f2395a9))
* Purchase Receipt Provisional Accounting GL Entries (backport [#37046](#37046)) ([#37068](#37068)) ([8772e40](8772e40))
* Remove redundant code ([#37001](#37001)) ([3ecdf02](3ecdf02))
* **ux:** move `get_route_options_for_new_doc` to `refresh` ([#37092](#37092)) ([a563fed](a563fed))
* validate duplicate serial no in DN ([fffa13f](fffa13f))

### Features

* provision to create RIV from `Stock Ledger Invariant Check` report (backport [#37115](#37115)) ([#37147](#37147)) ([29ff0ce](29ff0ce))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.40.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@commit-lint commit-lint bot mentioned this pull request Oct 23, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-aga-r s-aga-r Awaiting requested review from s-aga-r s-aga-r is a code owner

Assignees
No one assigned
Labels
backport develop instructs mergify to frontport PR to develop branch released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohitwaghchaure @frappe-pr-bot