fix: fetch logic for repay_from_salary in loan_repayment [v13] #37136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 13.53.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
frappe-pr-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
# [13.53.0](v13.52.15...v13.53.0) (2023-09-19) ### Bug Fixes * fetch logic for repay_from_salary in loan_repayment [v13] ([#37136](#37136)) ([d4f8b05](d4f8b05)) ### Features * provision to create RIV from `Stock Ledger Invariant Check` report (backport [#37115](#37115)) ([#37149](#37149)) ([86b152f](86b152f))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently checkboxes with
fetch_fromandfetch_if_emptyset (likerepay_from_salarycheck inloan_repaymentdoctype) don't work in the framework. We tried to fix it in the framework but we haven't come up with a solution which won't break lots of custom code. This PR fixes the issue until we come up with a long-term fix.