Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: editable purchase invoice #37194

Merged
merged 13 commits into from
Sep 26, 2023

Conversation

GursheenK
Copy link
Member

Enable updating selected fields in Purchase Invoice after submit and reposting the accounting entries.

Similar to Editable Sales Invoices - #32625

no-docs

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #37194 (61c6ebb) into develop (f0859ec) will decrease coverage by 0.04%.
Report is 37 commits behind head on develop.
The diff coverage is 97.14%.

❗ Current head 61c6ebb differs from pull request most recent head ed7f67b. Consider uploading reports for the commit ed7f67b to get more accurate results

@@             Coverage Diff             @@
##           develop   #37194      +/-   ##
===========================================
- Coverage    66.76%   66.73%   -0.04%     
===========================================
  Files          793      794       +1     
  Lines        62423    62515      +92     
===========================================
+ Hits         41679    41717      +38     
- Misses       20744    20798      +54     
Files Coverage Δ
...ounts/doctype/purchase_invoice/purchase_invoice.py 83.95% <100.00%> (+0.28%) ⬆️
...post_accounting_ledger/repost_accounting_ledger.py 100.00% <100.00%> (ø)
...xt/accounts/doctype/sales_invoice/sales_invoice.py 83.95% <100.00%> (+0.07%) ⬆️
erpnext/controllers/accounts_controller.py 85.46% <94.44%> (+0.34%) ⬆️

... and 5 files with indirect coverage changes

@ruthra-kumar ruthra-kumar self-assigned this Sep 26, 2023
@ruthra-kumar
Copy link
Member

@GursheenK I've added some logic to remove references on Repost Doctypes upon parent doc deletion, so that it doesn't block document deletion action.

Rest of the changes LGTM 👍

@ruthra-kumar ruthra-kumar merged commit 796cc09 into frappe:develop Sep 26, 2023
9 of 11 checks passed
@rtdany10
Copy link
Contributor

rtdany10 commented Oct 6, 2023

@GursheenK @ruthra-kumar backport to v14 as well please?

@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Oct 9, 2023
ruthra-kumar added a commit that referenced this pull request Oct 10, 2023
…-37194

feat: editable purchase invoice  (backport #37194)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants