Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allocate payment amount for split invoices in PE #37204

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

GursheenK
Copy link
Member

Bug
In Payment Entries, when reference invoices are fetched using the Get Outstanding Invoices button, the automatically allocated amount is calculated incorrectly for invoices split across multiple rows ie. invoices having some payment terms.

Example
When a Payment Entry with amount ₹1000 fetches the outstanding invoices for the party, the automatically allocated amount for invoices ends up as ₹4100 which is greater than the paid amount.

Screen.Recording.2023-09-22.at.12.50.02.PM.mov

Fix

Screen.Recording.2023-09-22.at.1.01.58.PM.mov

Closes #37078

no-docs

@ruthra-kumar
Copy link
Member

@GursheenK Fixing this in the server side method that does the term based splitting and allocation will be a better approach.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #37204 (545f2cc) into develop (b6437e3) will increase coverage by 0.00%.
Report is 11 commits behind head on develop.
The diff coverage is 10.60%.

@@           Coverage Diff            @@
##           develop   #37204   +/-   ##
========================================
  Coverage    66.70%   66.71%           
========================================
  Files          794      794           
  Lines        62491    62495    +4     
========================================
+ Hits         41687    41692    +5     
+ Misses       20804    20803    -1     
Files Changed Coverage
...ort/stock_ledger_variance/stock_ledger_variance.py 0.00%
...xt/accounts/doctype/payment_entry/payment_entry.py 66.66%
erpnext/accounts/utils.py 75.00%

@stale
Copy link

stale bot commented Oct 8, 2023

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 8, 2023
@ruthra-kumar
Copy link
Member

keep alive

@stale stale bot removed the inactive label Oct 10, 2023
@ruthra-kumar ruthra-kumar merged commit db317d6 into frappe:develop Oct 10, 2023
12 checks passed
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Oct 10, 2023
ruthra-kumar added a commit that referenced this pull request Oct 10, 2023
…-37204

fix: allocate payment amount for split invoices in PE (backport #37204)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Payment Entry Allocation
2 participants