fix: change currency exchange API to api.frankfurter.app #37355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
force-pushed
the
fix-exchange-rate
branch
from
60cf6b7
to
76919c4
Compare
|
Test case updated to use exchange rate from frankfurter. |
ruthra-kumar
force-pushed
the
fix-exchange-rate
branch
from
aa2319e
to
a3fd4db
Compare
|
@Mergifyio backport version-13 |
✅ Backports have been created
|
ruthra-kumar
added a commit
that referenced
this pull request
Oct 5, 2023
fix: change currency exchange API to api.frankfurter.app (backport #37355)
|
🎉 This PR is included in version 13.54.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
would it not make sense to place this URL to e.g. "Accounts Settings" to have the user chose from different providers if necessary any maybe only set a standard or fallback via hard-code? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api.exchangerate.host now requires an API key to use.
switching to api.frankfurter.app