Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add access_key field to facilitate use of exchangerate.host provider #37359

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Oct 4, 2023

Access Key is mandatory for exchangerate.host service provider. Currency Exchange Settings will have provision to add access_key to request parameter.
Screenshot 2023-10-04 at 3 51 49 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 4, 2023
@ruthra-kumar ruthra-kumar marked this pull request as ready for review October 4, 2023 10:26
@ruthra-kumar ruthra-kumar force-pushed the change_request_response_strucutre_on_exchangerate branch from c48f664 to c2880b4 Compare October 4, 2023 10:34
@ruthra-kumar ruthra-kumar changed the title refactor: add access_key field to facilitate use of exchangerate.host provide refactor: add access_key field to facilitate use of exchangerate.host provider Oct 4, 2023
@ruthra-kumar ruthra-kumar force-pushed the change_request_response_strucutre_on_exchangerate branch from f3bebe6 to 399c5aa Compare October 4, 2023 11:49
@ruthra-kumar ruthra-kumar force-pushed the change_request_response_strucutre_on_exchangerate branch from 399c5aa to c8e3dc6 Compare October 5, 2023 03:13
@ruthra-kumar ruthra-kumar merged commit c006c14 into frappe:develop Oct 5, 2023
11 of 12 checks passed
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Oct 5, 2023
ruthra-kumar added a commit that referenced this pull request Oct 5, 2023
…-37359

refactor: add `access_key` field to facilitate use of exchangerate.host provider (backport #37359)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant