fix: negative valuation rate in PR return (backport #37424) #37462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix: negative valuation rate in PR return * test: add test case for PR return (cherry picked from commit 26ad688) # Conflicts: # erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
mergify
bot
requested review from
deepeshgarg007,
rohitwaghchaure and
s-aga-r
as code owners
|
@Mergifyio backport version-13 |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Oct 11, 2023
* fix: negative valuation rate in PR return (#37424) * fix: negative valuation rate in PR return * test: add test case for PR return (cherry picked from commit 26ad688) # Conflicts: # erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py * chore: `conflicts` --------- Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com> (cherry picked from commit 66ad823)
s-aga-r
pushed a commit
that referenced
this pull request
Oct 11, 2023
…37462) (#37463) fix: negative valuation rate in PR return (backport #37424) (#37462) * fix: negative valuation rate in PR return (#37424) * fix: negative valuation rate in PR return * test: add test case for PR return (cherry picked from commit 26ad688) # Conflicts: # erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py * chore: `conflicts` --------- Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com> (cherry picked from commit 66ad823) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
## [13.54.5](v13.54.4...v13.54.5) (2023-10-19) ### Bug Fixes * e-commerce permissions for address (backport [#37554](#37554)) ([#37560](#37560)) ([49d0ab5](49d0ab5)) * **gp:** wrong `allocated_amount` on multi sales person invoice ([7805c3a](7805c3a)) * Issues related to RFQ and Supplier Quotation on Portal (backport [#37565](#37565)) (backport [#37577](#37577)) ([#37588](#37588)) ([bc907b2](bc907b2)) * keep customer/supplier website role by default ([52aff1f](52aff1f)) * negative valuation rate in PR return (backport [#37424](#37424)) ([#37462](#37462)) ([66ad823](66ad823)) * use `flt` to ignore TypeError (backport [#37481](#37481)) ([#37489](#37489)) ([8b4e692](8b4e692))
|
🎉 This PR is included in version 13.54.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #37424 done by Mergify.
Cherry-pick of 26ad688 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com