Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): repost utility deletion flag test #38679

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Dec 12, 2023

Fixes https://github.com/frappe/erpnext/actions/runs/7141720238/job/19450182186?pr=38643#step:13:623

No need to explicitly commit in the repost utility. If there are many vouchers, background job's default timeout is sufficient to handle it. For single doc repost, default request timeout should be fine to repost and commit.

Screenshot 2023-12-12 at 10 28 41 AM

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #38679 (acb6e8e) into develop (9424bbc) will decrease coverage by 0.09%.
Report is 30 commits behind head on develop.
The diff coverage is 16.66%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38679      +/-   ##
===========================================
- Coverage    60.16%   60.07%   -0.09%     
===========================================
  Files          759      759              
  Lines        69475    69531      +56     
===========================================
- Hits         41800    41774      -26     
- Misses       27675    27757      +82     
Files Coverage Δ
...post_accounting_ledger/repost_accounting_ledger.py 62.50% <100.00%> (-27.59%) ⬇️
erpnext/accounts/doctype/pricing_rule/utils.py 74.82% <0.00%> (-0.91%) ⬇️

... and 14 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 0acd0f5 into frappe:develop Dec 12, 2023
13 checks passed
ruthra-kumar added a commit that referenced this pull request Dec 12, 2023
…-38679

refactor(test): repost utility deletion flag test (backport #38679)
ruthra-kumar added a commit that referenced this pull request Dec 12, 2023
…-38679

refactor(test): repost utility deletion flag test (backport #38679)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant