Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: renamed number of depreciations booked to opening booked de… #41515

Merged

Conversation

khushi8112
Copy link
Member

@khushi8112 khushi8112 commented May 17, 2024

Refactor

In asset doctype when asset is existing asset, "Number of Depreciations Booked" field shows the opening number of depreciations booked. Which is confusing as user can misunderstand it as total number of booked depreciations.
So renamed "Number of Depreciations Booked" to "Opening Number of Booked Depreciations".

Feature

Added new field "Total Number of Booked Depreciations". As the name suggest it will show the total number of booked depreciations.

no-docs

@khushi8112 khushi8112 force-pushed the rename-number-of-depreciation-booked-field branch from 302738c to 163303e Compare May 23, 2024 07:44
@nabinhait nabinhait merged commit 6b0ce33 into frappe:develop May 28, 2024
12 of 13 checks passed
mergify bot pushed a commit that referenced this pull request May 28, 2024
#41515)

* refactor: renamed number of depreciations booked to opening booked depreciations

* feat: introduced new field for showing total number of booked depreciations

(cherry picked from commit 6b0ce33)

# Conflicts:
#	erpnext/assets/doctype/asset_finance_book/asset_finance_book.json
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
@khushi8112
Copy link
Member Author

@Mergifyio backport version-15-hotfix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants