refactor: remove use of can_create for Payment Request
#41647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barredterra
approved these changes
May 27, 2024
|
Thanks for the hotfix! The combination of "User cannot create" with a literal "Create" button seems weird. 🤔 Would it make sense to disable this setting? |
barredterra
added
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2024
(cherry picked from commit 47bc569) # Conflicts: # erpnext/selling/doctype/sales_order/sales_order.js
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2024
(cherry picked from commit 47bc569) # Conflicts: # erpnext/selling/doctype/sales_order/sales_order.js
Setting is fine, as it is better for Payment Request to be created only programmatically.
I think Framework needs some classification/mechanism to represent cases where the user is not allowed to create, but the Document can still be created programmatically. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression: #41384
Payment Requestis configured to be 'User Cannot Create'. So, it won't be available incan_createlist, which means the Payment Request option under theCreatebutton won't be available for anyone.Before
After