fix: consistent query field name in item wise purchase register with item wise sales register #41927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…item wise sales register
rohitwaghchaure
added a commit
that referenced
this pull request
Jun 17, 2024
…-41927 fix: consistent query field name in item wise purchase register with item wise sales register (backport #41927)
vorasmit
added
backport version-14-hotfix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_tax_accounts function was using the invoice_item.name field, which caused an issue in the purchase register because the item name was aliased as pii_item_name. This discrepancy led to taxes not being calculated correctly in the purchase register. This PR fixes the aliasing issue to ensure proper tax calculation.
Changes Made
Impact
Testing
Support Issue: