fix: Don't allow negative amount on Payment Request #41905

[hiteshprajapati]

[stale]

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

[hiteshprajapati]

@deepeshgarg007 @ruthra-kumar : is anything missing in this change?

[ruthra-kumar]

@hiteshprajapati
The Payment Request with a -ve amount in the screenshot, could you describe how that value came to be? Can you provide a simple replicable scenario?

[hiteshprajapati]

@hiteshprajapati The Payment Request with a -ve amount in the screenshot, could you describe how that value came to be? Can you provide a simple replicable scenario?

@ruthra-kumar : I am not sure whether I understand your question correctly.
About the screenshot, it is taken while creating payment request with -ve amount after making the code changes locally. Its new Payment Request and not the existing one and when I hit the save button, non-negative validation error returned by framework due to my changes

[hiteshprajapati]

@hiteshprajapati The Payment Request with a -ve amount in the screenshot, could you describe how that value came to be? Can you provide a simple replicable scenario?

@ruthra-kumar : I am not sure whether I understand your question correctly. About the screenshot, it is taken while creating payment request with -ve amount after making the code changes locally. Its new Payment Request and not the existing one and when I hit the save button, non-negative validation error returned by framework due to my changes

@ruthra-kumar : could you please provide your thoughts ? Its been here for a while

[ruthra-kumar]

@hiteshprajapati

From the screenshot, it looks like payment request is made against purchase order. But -ve purchase orders are not possible. So, how was the PO made?

[hiteshprajapati]

@hiteshprajapati

From the screenshot, it looks like payment request is made against purchase order. But -ve purchase orders are not possible. So, how was the PO made?

@ruthra-kumar : Yes, the payment request is made against the purchase order. But you can edit the amount while creating payment request from PO. Please refer this screenshot

paymentrequest_negative.mp4