Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pricing rule with and without 'apply multiple' and priority (backport #41976) #41998

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 23, 2024

Change in behavior on Apply Multiple Pricing Rules:
Apply Multiple Pricing Rules only takes effect when all the pricing rules identified for an item has it enabled. Else, Priority is applied and only the highest priority takes effect.

Combining rules with and without Apply Multiple Pricing Rules enabled doesn't make sense. Hence the change.


This is an automatic backport of pull request #41976 done by Mergify.

Either all of the pricing rules identified for an item should have
'apply multiple' enabled. If not, Priority is applied and only the
highest priority is applied

(cherry picked from commit 5e875b2)
@ruthra-kumar ruthra-kumar merged commit 521cfb3 into version-15-hotfix Jun 23, 2024
12 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-15-hotfix/pr-41976 branch June 23, 2024 00:19
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants