Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multiple fixes in Bank Statement Import #42026

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

ljain112
Copy link
Contributor

@ljain112 ljain112 commented Jun 25, 2024

Fixes for consistency with data import tool in frappe

  • Custom Delimitor (consistency with frappe)
  • Deprecated statement_import_log
  • Use Data Import Log for import_status, Import Log preview

Backport:

  • version-15
  • version-14

Closes: #42017
Frappe Support Issue: https://support.frappe.io/helpdesk/tickets/17549

Before:
image
After:
image

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 25, 2024
@ruthra-kumar ruthra-kumar self-assigned this Jul 3, 2024
@ruthra-kumar ruthra-kumar merged commit 2383a1a into frappe:develop Jul 9, 2024
22 checks passed
ruthra-kumar added a commit that referenced this pull request Jul 10, 2024
…-42026

fix:  Multiple fixes in Bank Statement Import (backport #42026)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import Log is not shown in Bank Statement Import
2 participants