fix: timeout error while submitting JV #42040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitwaghchaure
requested review from
s-aga-r,
deepeshgarg007 and
ruthra-kumar
as code owners
github-actions
bot
added
accounts
needs-tests
rohitwaghchaure
force-pushed
the
fixed-support-17711
branch
2 times, most recently
from
e24368e
to
4c4928f
Compare
|
https://github.com/frappe/erpnext/blob/develop/erpnext/stock/utils.py#L80:L84 The code retrieving the child warehouses is also important to optimise IMO. Shouldn't the warehouse account map already have all the child warehouses? In that case, is any query for getting child warehouses required at all? Maybe we should have a flag like Even when fetching child warehouses is necessary, can't we get this information from the warehouse account map itself? (we may need to fetch Apart from that, indexing of posting date will also help I think. |
sagarvora
reviewed
Jun 27, 2024
rohitwaghchaure
force-pushed
the
fixed-support-17711
branch
6 times, most recently
from
e333f36
to
a977291
Compare
rohitwaghchaure
force-pushed
the
fixed-support-17711
branch
from
a977291
to
a1ec1cb
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 29, 2024
(cherry picked from commit 32bdcdb) # Conflicts: # erpnext/accounts/doctype/account/account.json # erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py # erpnext/accounts/utils.py # erpnext/stock/doctype/stock_ledger_entry/stock_ledger_entry.json
rohitwaghchaure
added a commit
that referenced
this pull request
Jul 1, 2024
* fix: timeout error while submitting JV (#42040) (cherry picked from commit 32bdcdb) # Conflicts: # erpnext/accounts/doctype/account/account.json # erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py # erpnext/accounts/utils.py # erpnext/stock/doctype/stock_ledger_entry/stock_ledger_entry.json * chore: fix conflicts * chore: fix conflicts * chore: fix conflicts * chore: fix conflicts --------- Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
Poorvi-R-Bhat
pushed a commit
to Poorvi-R-Bhat/erpnextdev
that referenced
this pull request
Jul 3, 2024
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
# [15.29.0](v15.28.2...v15.29.0) (2024-07-03) ### Bug Fixes * add auto-update for overdue status ([#42105](#42105)) ([317cc03](317cc03)) * add string for translation (backport [#41903](#41903)) ([#41963](#41963)) ([48dc24b](48dc24b)) * always post to tax account heads if LCV is booked ([706a6c1](706a6c1)) * batch picking in pick list based on Stock Settings (backport [#42021](#42021)) ([#42134](#42134)) ([a45f8ca](a45f8ca)) * batch reset while making SABB (backport [#42076](#42076)) ([#42123](#42123)) ([c3f5a49](c3f5a49)) * decimal issue in pick list (backport [#41972](#41972)) ([#41982](#41982)) ([9945a90](9945a90)) * **Delivery Note:** only show permitted actions ([cef6d0d](cef6d0d)) * do not show zero balance stock items in stock balance report (backport [#41958](#41958)) ([#41961](#41961)) ([c10b123](c10b123)) * expense account from item group not fetched (backport [#41957](#41957)) ([#41962](#41962)) ([760b2e2](760b2e2)) * fixed asset value in Fixed Asset Register (backport [#41930](#41930)) ([#42027](#42027)) ([f2feeaf](f2feeaf)) * handle none type object error ([b0aef9e](b0aef9e)) * incorrect against_account upon reposting ([a41577a](a41577a)) * incorrect Difference Amount (backport [#42008](#42008)) ([#42013](#42013)) ([838cc5b](838cc5b)) * incorrect discount on other item ([77f4199](77f4199)) * incorrect dr/cr on Adv Payment against Journals ([4e74257](4e74257)) * incorrect time period in asset depreciation schedule (backport [#41805](#41805)) ([#42043](#42043)) ([cf4d4ba](cf4d4ba)) * lead status filter (backport [#41816](#41816)) ([#42046](#42046)) ([3536a75](3536a75)) * manufacturing date issue in the batch (backport [#42034](#42034)) ([#42037](#42037)) ([a981633](a981633)) * move condition for shipment ([2180239](2180239)) * not able to make purchase return (backport [#42053](#42053)) ([#42055](#42055)) ([8a91bf3](8a91bf3)) * pricing rule with and without 'apply multiple' and priority ([f3aa885](f3aa885)) * provisional entry for non stock items ([d61dab8](d61dab8)) * Re-open allows SO's to be over credit limit ([7fcb0f5](7fcb0f5)) * refactor Asset Repair and Stock Entry linkage to resolve amendme… (backport [#41919](#41919)) ([#42058](#42058)) ([97c49b9](97c49b9)) * reload asset when creating asset depreciation ([7b5d504](7b5d504)) * reposting file attachment permission issue (backport [#42068](#42068)) ([#42075](#42075)) ([1f3374f](1f3374f)) * resolve gl entries duplication in asset purchase workflow (backport [#41845](#41845)) ([#42120](#42120)) ([58e18e2](58e18e2)) * **Sales Order:** only show permitted actions ([a0011c5](a0011c5)) * show zero stock items filter in the stock balance report (backport [#42147](#42147)) ([#42152](#42152)) ([11ebbf2](11ebbf2)) * stock qty validation in SCR (backport [#42124](#42124)) ([#42133](#42133)) ([d9e62fe](d9e62fe)) * Stock Reservation Entry was not getting created (backport [#42033](#42033)) ([#42035](#42035)) ([e278fc6](e278fc6)) * **test:** incorrect field for customer default billing currency ([3b15708](3b15708)) * this.frm.events.update_cost is not a function (backport [#41960](#41960)) ([#41965](#41965)) ([3b4d397](3b4d397)) * timeout error while submitting JV (backport [#42040](#42040)) ([#42099](#42099)) ([a0e06a4](a0e06a4)) * timeout while cancelling LCV (backport [#42030](#42030)) (backport [#42031](#42031)) ([#42032](#42032)) ([068de08](068de08)) * unhide serial no field (backport [#42045](#42045)) ([#42047](#42047)) ([482832f](482832f)) * valuation rate for the legacy batches (backport [#42011](#42011)) ([#42020](#42020)) ([f6be19c](f6be19c)) * Wrong Delete Batch on Purchase Receipt (backport [#42007](#42007)) ([#42012](#42012)) ([68b318a](68b318a)) ### Features * accounting dimension filters in gp report ([fe9dffb](fe9dffb)) * default account head for operating cost (backport [#41985](#41985)) ([#41987](#41987)) ([44c1671](44c1671)) * **gp:** group by cost center ([068ae87](068ae87)) * Turkish Chart Of Accounts (backport [#41756](#41756)) ([#42028](#42028)) ([63b26e6](63b26e6)) ### Performance Improvements * code optimization to handle large asset creation (backport [#42018](#42018)) ([#42025](#42025)) ([c27f272](c27f272)) * dont run queries unnecessarily, improved filters ([#41993](#41993)) ([b59c91a](b59c91a)) * Performance optmization for Purchase Invoice submission (backport [#40263](#40263)) ([#41946](#41946)) ([d396c18](d396c18))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The timeout error was coming while submitting the JV (269.251 seconds ), did profiling and found that the get_stock_value_on method is taking time.
This method is used to get the total stock value based on the warehouse filter. The number of warehouses is determined by the stock account that the user has selected in the JV.
The user who reported this issue has a single stock account but around 10,800 warehouses, causing the query to be formed as shown below (in the screenshot, the query is only partially visible).
Solution
To optimize the query, removed the warehouse checks condition for instances having a single stock account. With this change, the system was able to submit the JV in 56 seconds.