Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated logic for calculating tax_withholding_net_total in payment entry #42060

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

ljain112
Copy link
Contributor

@ljain112 ljain112 commented Jun 27, 2024

Issue:

Earlier TDS was deducted on base_tax_withholding_net_total even if the allocated amount is less than base_tax_withholding_net_total amount.

For eg:
PO = 100 + 18 = 118
Base Tax Withholding Net Total = 100
o/s amount = 118
Paid amount = 50
Net Total Amount= 100

Fix:

Now TDS will be deducted on net_payable_amount_before tax or allocated amount whichever is less.
For eg:

PO = 100 + 18 = 118
Base Tax Withholding Net Total = 100

1st Payment Entry
o/s amount = 118
Paid amount = 50
Net Base Tax Withholding Payable = 118-18 = 100
Net Total Amount= 50

2nd Payment Entry
o/s amount = 68
Paid amount = 60
Net Base Tax Withholding Payable = 68-18 = 50
Net Total Amount= 50

3rd Payment Entry
o/s amount = 8
Paid amount = 8
Net Base Tax Withholding Payable = 0
Net Total Amount= 0

Suppot Issue: https://support.frappe.io/helpdesk/tickets/17745

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 27, 2024
@ljain112 ljain112 force-pushed the fix-tds branch 3 times, most recently from 099d0fe to 5865847 Compare June 28, 2024 05:55
@ljain112 ljain112 changed the title fix: correct net total for tds deduction in payment entry fix: updated logic for calculating tax_withholding_net_total in payment entry Jun 28, 2024
@ljain112 ljain112 marked this pull request as ready for review June 28, 2024 06:05
@ljain112 ljain112 force-pushed the fix-tds branch 2 times, most recently from 575dbfe to 5467def Compare July 2, 2024 13:28
@vorasmit vorasmit merged commit d86e0ad into frappe:develop Jul 10, 2024
13 checks passed
sagarvora added a commit that referenced this pull request Jul 10, 2024
…-42060

fix: updated logic for calculating tax_withholding_net_total in payment entry (backport #42060)
@sagarvora sagarvora added the backport version-14-hotfix backport to version 14 label Jul 10, 2024
sagarvora added a commit that referenced this pull request Jul 10, 2024
…-42060

fix: updated logic for calculating tax_withholding_net_total in payment entry (backport #42060)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants