Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Re-open allows SO's to be over credit limit #42126

Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix: Re-open allows SO's to be over credit limit #42126

merged 2 commits into from
Jul 1, 2024

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Jul 1, 2024 •
edited
Loading

  1. Make Sales Order within Credit Limit
  2. Set status to 'Close'
  3. Make another Sales Order within Credit Limit. Both the Sales Order should be over the limit
  4. Reopen sales order [1]

Credit LImit validation should prevent Re-opening.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 1, 2024
@ruthra-kumar ruthra-kumar removed the needs-tests This PR needs automated unit-tests. label Jul 1, 2024
@ruthra-kumar ruthra-kumar merged commit cbd25ae into frappe:develop Jul 1, 2024
13 checks passed
This was referenced Jul 1, 2024
Merged
Merged
ruthra-kumar added a commit that referenced this pull request Jul 1, 2024
@ruthra-kumar
Merge pull request #42132 from frappe/mergify/bp/version-15-hotfix/pr…
61c0ce6 
…-42126

fix: Re-open allows SO's to be over credit limit (backport #42126)
ruthra-kumar added a commit that referenced this pull request Jul 1, 2024
@ruthra-kumar
Merge pull request #42131 from frappe/mergify/bp/version-14-hotfix/pr…
d5366c5 
…-42126

fix: Re-open allows SO's to be over credit limit (backport #42126)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ruthra-kumar