Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multiple fixes for General Ledger Report #42146

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

ljain112
Copy link
Contributor

@ljain112 ljain112 commented Jul 2, 2024

  • Optimise query for getting all child docs
  • Translation as constant can create issue in multi-tenant environment.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 2, 2024
@ljain112 ljain112 marked this pull request as ready for review July 2, 2024 13:32
@sagarvora sagarvora removed the needs-tests This PR needs automated unit-tests. label Jul 2, 2024
@ruthra-kumar ruthra-kumar self-assigned this Jul 5, 2024
@ruthra-kumar ruthra-kumar merged commit 4cea34c into frappe:develop Jul 6, 2024
13 checks passed
@ruthra-kumar
Copy link
Member

@sagarvora
Does this require backporting?

sagarvora added a commit that referenced this pull request Jul 8, 2024
…-42146

fix: Multiple fixes for General Ledger Report (backport #42146)
@sagarvora
Copy link
Collaborator

@sagarvora Does this require backporting?

I've done the needful.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants