Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reopen Project if Completion Percentage is Below 100% #42204

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

DaizyModi
Copy link
Contributor

@DaizyModi DaizyModi commented Jul 6, 2024

Before

When a project is marked as completed, reopening any task within it will not change the project's status from Completed.

Project.Status.Before.Change.mov

After

If any task is reopened after the project is completed, the project's status will be updated to Open.

Project.Status.After.Change.mov

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 6, 2024
@vorasmit vorasmit merged commit 3ef7e6c into frappe:develop Jul 10, 2024
14 of 15 checks passed
vorasmit added a commit that referenced this pull request Jul 10, 2024
…-42204

fix: Reopen Project if Completion Percentage is Below 100% (backport #42204)
@sjoulaei
Copy link

A mess was caused in our system which I believe stems from this update.

  1. All of our old completed projects have been re-opened because there was an open task in them. (we may be able to work around this)
  2. Any project that has all tasks in it completed is closed off automatically (we don't want this)
  3. Any project that hasn't got any tasks in it can not be closed off (definitely don't want this)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants