Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Multiple fixes in Bank Statement Import (backport #42026) #42240

Merged
merged 8 commits into from
Jul 10, 2024
Merged

fix: Multiple fixes in Bank Statement Import (backport #42026) #42240

merged 8 commits into from
Jul 10, 2024

Commits on Jul 9, 2024

  1. fix: custom delimiters 

    (cherry picked from commit 13fb560)

# Conflicts:
#	erpnext/accounts/doctype/bank_statement_import/bank_statement_import.json
    @ljain112 @mergify
    ljain112 authored and mergify[bot] committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    43ad2fe View commit details
    Browse the repository at this point in the history

  2. fix: remove deprecated field "statement_import_log" 

    (cherry picked from commit b202409)

# Conflicts:
#	erpnext/accounts/doctype/bank_statement_import/bank_statement_import.json
    @ljain112 @mergify
    ljain112 authored and mergify[bot] committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2f0b97d View commit details
    Browse the repository at this point in the history

  3. fix: import status 

    (cherry picked from commit 07f6888)
    @ljain112 @mergify
    ljain112 authored and mergify[bot] committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    71311ff View commit details
    Browse the repository at this point in the history

  4. fix: import log preview 

    (cherry picked from commit 1ad264d)
    @ljain112 @mergify
    ljain112 authored and mergify[bot] committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    62aac8b View commit details
    Browse the repository at this point in the history

  5. fix: download_import_log if rows are greater than 5000 

    (cherry picked from commit 2112d8f)
    @ljain112 @mergify
    ljain112 authored and mergify[bot] committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    4eb251b View commit details
    Browse the repository at this point in the history

  6. fix: field position 

    (cherry picked from commit 98ad01c)

# Conflicts:
#	erpnext/accounts/doctype/bank_statement_import/bank_statement_import.json
    @ljain112 @mergify
    ljain112 authored and mergify[bot] committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a04938d View commit details
    Browse the repository at this point in the history

  7. fix: changes as per review 

    (cherry picked from commit ba08b2e)
    @ljain112 @mergify
    ljain112 authored and mergify[bot] committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    57896a8 View commit details
    Browse the repository at this point in the history

  8. chore: resolve conflict

    @ruthra-kumar
    ruthra-kumar committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f281e06 View commit details
    Browse the repository at this point in the history