Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Warehouse): add buttons only if the user can use them (backport #42232) #42273

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 10, 2024

Avoid adding buttons that will throw a permission error when the user clicks on them.

Before

frm.add_custom_button()

After

if (has_required_perm()) {
    frm.add_custom_button()
}

This is an automatic backport of pull request #42232 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from rohitwaghchaure as a code owner July 10, 2024 11:15
@mergify mergify bot requested a review from s-aga-r as a code owner July 10, 2024 11:15
@barredterra barredterra merged commit 2751a9a into version-15-hotfix Jul 10, 2024
6 checks passed
@barredterra barredterra deleted the mergify/bp/version-15-hotfix/pr-42232 branch July 10, 2024 13:26
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants