Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set pos data if not return doc #42386

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

ljain112
Copy link
Contributor

@ljain112 ljain112 commented Jul 18, 2024

POS Data is not set in all documents due to #42287.

It should not be set in return documents only.

Internal Issue: https://support.frappe.io/app/hd-ticket/18971

@ljain112 ljain112 changed the title fix: do not set pos data only if it is return invoice fix: set pos data if not return doc Jul 18, 2024
@ljain112 ljain112 marked this pull request as ready for review July 18, 2024 12:11
@ruthra-kumar ruthra-kumar self-assigned this Jul 19, 2024
@ruthra-kumar ruthra-kumar merged commit f44de67 into frappe:develop Jul 19, 2024
13 checks passed
ruthra-kumar added a commit that referenced this pull request Jul 19, 2024
…-42386

fix: set pos data if not return doc (backport #42386)
vorasmit added a commit that referenced this pull request Jul 25, 2024
…-42386

fix: set pos data if not return doc (backport #42386)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants