feat: add make_regional_gl_entries override for Sales Invoice #42399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make_regional_gl_entries
FHenry
requested review from
deepeshgarg007,
rohitwaghchaure and
ruthra-kumar
as code owners
vorasmit
reviewed
Jul 19, 2024
FHenry
changed the title
|
@vorasmit |
mergify bot
pushed a commit
that referenced
this pull request
Jul 20, 2024
* feat: add make_regional_gl_entries override for Sales Invoice and Stock Controler * chore: remove regionnal override for stock management (cherry picked from commit 1bbe020)
vorasmit
added a commit
that referenced
this pull request
Jul 20, 2024
…-42399 feat: add make_regional_gl_entries override for Sales Invoice (backport #42399)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
# [15.31.0](v15.30.0...v15.31.0) (2024-07-24) ### Bug Fixes * Consider adding warranty period to serial nos (backport [#42051](#42051)) ([#42182](#42182)) ([8da28dc](8da28dc)) * correct validation for depreciation posting date ([ffacf42](ffacf42)) * Don't allow negative amount on Payment Request [#41905](#41905) ([aee2cc2](aee2cc2)) * missing cr/dr notes on payment reconciliation ([0a41ccd](0a41ccd)) * not able to save QC (backport [#42371](#42371)) ([#42373](#42373)) ([18500b8](18500b8)) * provide initial value for `.reduce()` call ([72bc539](72bc539)) * Purchase Order Analysis Report Data (backport [#42387](#42387)) ([#42394](#42394)) ([709be13](709be13)) * qty in the 'Serial No Ledger' report (backport [#42429](#42429)) ([#42433](#42433)) ([926fd41](926fd41)) * remove proprietorship and update it with individual ([527781a](527781a)) * rounding issue causing incorrect quantity in SE (backport [#42380](#42380)) ([#42395](#42395)) ([54791e9](54791e9)) * serial and batch bundle for POS Invoice (backport [#41491](#41491)) ([#42396](#42396)) ([555be2b](555be2b)) * set filter to show only submitted asset ([29fc975](29fc975)) * Show the rows in AR/AP report where outstanding equals to 0.01 ([886256c](886256c)) ### Features * add make_regional_gl_entries override for Sales Invoice ([#42399](#42399)) ([22b17de](22b17de))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following review on #42278
For a common feature in France/Europe (but missing in ERPNext core), we've introduce in France Regional Localization app (https://github.com/scopen-coop/erpnext_france), the "Deposit invoice". That's a real Sales invoices / Purchase Invoice issuing (not Payment Request) based on % or fixed amount from a Sales Order / Purchase Order .
We need to adapt make_gl_entries and make_reverse_gl_entries method because the actual tax accounting is not correct according regional accountancy law.
Income amount from this type of invoice can have a different Account, and Tax amount could be accounted in split/spread Accounts if it talk about Goods or Service or also, but not only, depend Customer/Supplier country, and other case...
Actually, we almost manage to update GL entry after core ERPNext make_gl_entries/make_reverse_gl_entries but that not the good way of doing things.
This missing "@erpnext.allow_regional" on these methods force us to spend a lot's of time to "hack" ERPNext, and in some case do not allow to implement the legal requirement for France accounting law.
Let me know what do you think about this PR