refactor: better UX on Bank Clearance tool (backport #42979) #42981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
While updating Clearance date using Bank Clearance tool, if there were any errors,
Update Clearance Toolbutton gets disabled, prohibiting further use. You have to reload the whole page, set filters (again) and pull payment entries (again), for the button be active again. This flow is unergonomic.Fix
Use
frm.refreshto reload the entire form and move the button addition logic to the standardrefreshfunction.Before
before.mp4
After
after.mp4
This is an automatic backport of pull request #42979 done by [Mergify](https://mergify.com).