Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AP filter to simulate employee advance as a ledger impacting voucher (backport #43070) #43074

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 5, 2024

Issue

Expense Claims, Payment Entries and Journals allocated against Employee advance show up in Accounts Payable report as individual (unreconciled) entries. This is a known limitation in the system.

Cause

Accounts Payable report relies on the Primary document having Ledger impact to work properly. Since, Employee Advances don't post any ledger entries, Exp Claims or Payments allocated against advances cannot be linked with each other and hence end up reported as unallocated.

Workaround

AP report has a new filter 'Handle Employee Advances' to handle above scenario.


This is an automatic backport of pull request #43070 done by Mergify.

(cherry picked from commit 257e13c)

# Conflicts:
#	erpnext/accounts/report/accounts_payable/accounts_payable.js
Copy link
Contributor Author

mergify bot commented Sep 5, 2024

Cherry-pick of 257e13c has failed:

On branch mergify/bp/version-15-hotfix/pr-43070
Your branch is ahead of 'origin/version-15-hotfix' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 257e13c299.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/accounts/report/accounts_receivable/accounts_receivable.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/report/accounts_payable/accounts_payable.js

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 5, 2024
@ruthra-kumar ruthra-kumar merged commit c31b4e6 into version-15-hotfix Sep 6, 2024
11 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-15-hotfix/pr-43070 branch September 6, 2024 04:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant